loader: Fix "Skipping symbol substitution" warnings #10934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pchaigno
added
the
release-note/misc
These warning messages generally indicate that a new map was introduced or renamed and the list of symbols in ignoredELFPrefixes wasn't updated. Signed-off-by: Paul Chaignon <paul@cilium.io>
A new IP frag. map was introduced, but the list of symbols to skip in the
ELF wasn't updated, resulting in the following warning:
2020-04-10T15:08:21.073661843Z level=warning msg="Skipping symbol substitution" subsys=elf symbol=cilium_ipv4_frag_datagrams
Fixes: #10264
Signed-off-by: Paul Chaignon <paul@cilium.io>
If IPv6 was just enabled and the endpoint restored, it's possible for the template BPF object file to have the LXC_IP_* symbols while the endpoint doesn't. We therefore don't generate a warning in that case. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/fix-warning-ipfrag-map-symbol
branch
from
6b72eb5
to
926eb90
Compare
pchaigno
changed the title
pchaigno
added
area/CI
joestringer
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds symbol substitution warnings to
badLogMessagesand fixes two occurrences in tests, namelycilium_ipv4_frag_datagramsandLXC_IP_. See commit messages for details.