docker, runtime: only build clang and llc targets #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
pending-review
release-note/misc
|
test-me-please |
borkmann
approved these changes
Apr 14, 2020
aanm
approved these changes
Apr 14, 2020
tklauser
force-pushed
the
pr/tklauser/docker-runtime-llvm-targets
branch
from
197e4cb
to
1661e19
Compare
|
test-me-please EDIT: failure looks like #10882 https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18735/ |
Specify only the targets we need from the llvm build, namely `clang` and `llc`. This reduces the amount of objects to build by ~300 and thus also reduces build time a bit. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/docker-runtime-llvm-targets
branch
from
1661e19
to
d77ff8b
Compare
|
test-me-please |
|
test-me-please |
1 similar comment
|
test-me-please |
|
Hit #10838 |
|
test-me-please |
|
test-me-please EDIT: hit #10929 again https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18792/ |
|
restart-ginkgo EDIT: hit #10929 again https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18806/ |
|
test-with-kernel |
|
test-gke |
|
restart-ginkgo EDIT: net-next vm provisioning failure https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18814/ |
|
restart-ginkgo |
1 similar comment
|
restart-ginkgo |
|
restart-ginkgo |
After updating the cilium-runtime image we also get a newer bpftool build which generates a bpf_features.h header that includes the netns cookie and therefore on bpf-next kernel we must fail this particular test. Similarly, doFragmentedRequest() from pod loopback does not make sense either anymore. Given we performed the earlier testCurlRequestFail() for a service, there is no point in retesting a fragmented request again for this address. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
force-pushed
the
pr/tklauser/docker-runtime-llvm-targets
branch
from
024cead
to
06b1501
Compare
|
test-me-please |
aanm
approved these changes
Apr 16, 2020
|
Did you create a PR for cilium/packer-ci-build to cache the updated Docker image in the CI VM images? |
tklauser
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Apr 17, 2020
This will pull in Go 1.14.2 via cilium/cilium#10912 and the build llvm changes from cilium/cilium#10956 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added a commit
to cilium/packer-ci-build
that referenced
this pull request
Apr 17, 2020
This will pull in Go 1.14.2 via cilium/cilium#10912 and the build llvm changes from cilium/cilium#10956 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@brb Thanks for the reminder. Opened PR cilium/packer-ci-build#208 |
brb
pushed a commit
to cilium/packer-ci-build
that referenced
this pull request
Apr 18, 2020
This will pull in Go 1.14.2 via cilium/cilium#10912 and the build llvm changes from cilium/cilium#10956 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added a commit
to cilium/packer-ci-build
that referenced
this pull request
May 25, 2020
Specify only the targets we need from the llvm build, namely `clang` and `llc`. This reduces the amount of objects to build by ~300 and thus also reduces build time a bit. Same as cilium/cilium#10956 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added a commit
to cilium/packer-ci-build
that referenced
this pull request
May 25, 2020
Specify only the targets we need from the llvm build, namely `clang` and `llc`. This reduces the amount of objects to build by ~300 and thus also reduces build time a bit. Same as cilium/cilium#10956 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added a commit
to cilium/packer-ci-build
that referenced
this pull request
May 26, 2020
Specify only the targets we need from the llvm build, namely `clang` and `llc`. This reduces the amount of objects to build by ~300 and thus also reduces build time a bit. Same as cilium/cilium#10956 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify only the targets we need from the llvm build, namely
clangandllc. This reduces the amount of objects to build by ~300 and thusalso reduces build time a bit.
(Edit from @borkmann: added the test update commit which fixes below issue)
Fixes: #10882