Preparatory refactoring for dynamic BPF map sizing #10957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparatory refactoring to move map size clamping into a separate function. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
pending-review
kind/cleanup
|
test-me-please |
This matches the other map entry size vars and also avoids confusion with the const PolicyMapMax used for upper bound policy map size. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Refactoring in preparation for introducing dynamic map sizes. Also add some tests. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/bpf-map-prep-refactoring
branch
from
bd900fe
to
8691c47
Compare
|
test-me-please EDIT: failure looks like #10942 https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18720/ |
pchaigno
approved these changes
Apr 14, 2020
|
restart-ginkgo |
qmonnet
approved these changes
Apr 14, 2020
vadorovsky
approved these changes
Apr 14, 2020
|
@tklauser Why are these limits enforced? The underlying maps support __u32 map size. |
@joestringer you mean the upper limits on map sizes? I'm not sure (or can't remember) to be honest. AFAIR, these were defined already before the refactoring and I just refactored the code so the limits could be tested. |
|
Ah I see, sorry for the noise. I traced back the variable but didn't look so closely at the PR. I guess it's just always been a restriction like that. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparatory refactoring before the next iteration of #10780.
This moves the checking of the map size limits to its own, testable function and adds accompanying tests.
Reviewable by commit.