Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: GKE more cleaning #10965

Merged
merged 2 commits into from Apr 14, 2020
Merged

CI: GKE more cleaning #10965

merged 2 commits into from Apr 14, 2020

Conversation

raybejjani
Copy link
Contributor

  • Despite having cleanup logic the istio tests seem to leak. This is
    likely because these tests are hard-interrupted. We clean up in our
    release script since we know that these pods should no longer exist.

soooo

  • We are interrupted by jenkins on timeouts, and this can happen while we
    scale the cluster down. We now unlock in an exit trap and this should,
    hopefully, leave the cluster reusable, if not well cleaned.

@raybejjani
CI: Cleanup istio-system namespace
976fad7 
Despite having cleanup logic the istio tests seem to leak. This is
likely because these tests are hard-interrupted. We clean up in our
release script since we know that these pods should no longer exist.

Signed-off-by: Ray Bejjani <ray@isovalent.com>
@raybejjani
CI: Handle GKE lock release in a trap
4d60573 
We are interrupted by jenkins on timeouts, and this can happen while we
scale the cluster down. We now unlock in an exit trap and this should,
hopefully, leave the cluster reusable, if not well cleaned.

Signed-off-by: Ray Bejjani <ray@isovalent.com>
@raybejjani raybejjani added pending-review area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Apr 14, 2020
@raybejjani raybejjani requested a review from nebril April 14, 2020 12:20
@raybejjani raybejjani requested a review from a team as a code owner April 14, 2020 12:20
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 14, 2020
@raybejjani
Copy link
Contributor Author

raybejjani commented Apr 14, 2020 •
edited

test-gke K8sDemosTest.* (passed)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 46.593% when pulling 4d60573 on raybejjani:ci-gke-more-cleaning into afc48b7 on cilium:master.

@raybejjani
Copy link
Contributor Author

raybejjani commented Apr 14, 2020 •
edited

test-gke K8sDemosTest.* (passed)

@raybejjani
Copy link
Contributor Author

test-gke K8sDemosTest.*

@raybejjani raybejjani merged commit fe51032 into cilium:master Apr 14, 2020
1.8.0 automation moved this from In progress to Merged Apr 14, 2020
@raybejjani raybejjani deleted the ci-gke-more-cleaning branch April 15, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raybejjani @coveralls @nebril