Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix cleanup on gke job #10995

Merged
merged 1 commit into from Apr 16, 2020
Merged

ci: Fix cleanup on gke job #10995

merged 1 commit into from Apr 16, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Apr 15, 2020

No description provided.

@nebril
ci: Fix cleanup on gke job
3890ba6 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril requested a review from a team as a code owner April 15, 2020 13:37
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 15, 2020
@nebril
Copy link
Member Author

nebril commented Apr 15, 2020

test-me-please

@nebril
Copy link
Member Author

nebril commented Apr 15, 2020

test-gke

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Apr 15, 2020
raybejjani
raybejjani approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@raybejjani raybejjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment to explain what these steps do but LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 46.785% when pulling 3890ba6 on pr/cleanup-gke-job into 263fbd5 on master.

@aanm aanm merged commit b4c1fb5 into master Apr 16, 2020
1.8.0 automation moved this from In progress to Merged Apr 16, 2020
@aanm aanm deleted the pr/cleanup-gke-job branch April 16, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raybejjani raybejjani raybejjani approved these changes

Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nebril @coveralls @raybejjani @aanm