test: Check kubectl with 'which' instead of 'dpkg -l' #10998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When k8s install falls back to binary install kubelet does not exist as a package, but exists in the path. Use 'which kubelet' to check k8s install instead of 'dpkg -l' to cover both install methods. This change fixes the failure to run ginkgo again on an already running set of k8s nodes when k8s has been installed as binaries. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/bug/CI
|
test-me-please |
joestringer
approved these changes
Apr 15, 2020
aanm
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When k8s install falls back to binary install kubelet does not exist
as a package, but exists in the path. Use 'which kubelet' to check k8s
install instead of 'dpkg -l' to cover both install methods.
This change fixes the failure to run ginkgo again on an already
running set of k8s nodes when k8s has been installed as binaries.
Signed-off-by: Jarno Rajahalme jarno@covalent.io