build: Remove sysctl from Dockerfiles
#11017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These actually had no intended effect, they only resulted in error messages at buildtime. Any `sysctl` calls need to be done at runtime agianst a running kernel, but clearly there is no issue at the moment, so best to just get rid of these. The only logic that does anything with coredumps is in test helpers - `GatherCiliumCoreDumps`, and that only looks for filenames that contain `core`. Fixes: #10683 Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
added
release-note/misc
pchaigno
approved these changes
Apr 16, 2020
|
test-me-please |
vadorovsky
approved these changes
Apr 16, 2020
|
restart-ginkgo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.