Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for docker getting-started example #11022

Merged
merged 2 commits into from Apr 17, 2020
Merged

Conversation

tklauser
Copy link
Member

  • bump cilium version in Docker getting-started example to 1.7.2
  • add bind mount for /var/lib/cilium to docker-compose.yml

Found while working on a fix for #10962 (separate PR, as this only affects master and doesn't need to be backported)

While at it also bump the docker-compose version to the latest 1.25.5

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
…r-compose.yml

The datapath template files are installed in /var/lib/cilium instead of
being compiled into cilium-agent since commit ff22f48 ("make:
remove the need for go-bindata").

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Apr 16, 2020
@tklauser tklauser requested review from a team as code owners April 16, 2020 20:33
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 16, 2020
@tklauser
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 46.784% when pulling 42ca148 on pr/tklauser/docker-gsg into 8b74e24 on master.

Copy link
Contributor

@soumynathan soumynathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgraf tgraf merged commit eca8c98 into master Apr 17, 2020
1.8.0 automation moved this from In progress to Merged Apr 17, 2020
@tgraf tgraf deleted the pr/tklauser/docker-gsg branch April 17, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants