Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: Log WriteMsgIP details. #11037

Merged
merged 1 commit into from
Apr 27, 2020
Merged

dns: Log WriteMsgIP details. #11037

merged 1 commit into from
Apr 27, 2020

Conversation

jrajahalme
Copy link
Member

Add detail to WriteMsgIP log messages in hopes to understand why we
sometimes see a lot of these logs.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. pending-review area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels Apr 17, 2020
@jrajahalme jrajahalme requested a review from a team April 17, 2020 15:32
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.3 Apr 17, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 17, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/dnsproxy-add-udp-logging-detail branch 2 times, most recently from 20b1c7f to 7fc8b04 Compare April 17, 2020 16:59
@jrajahalme
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Apr 17, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 44.75% when pulling 5db77d0 on pr/jrajahalme/dnsproxy-add-udp-logging-detail into 3c44ae5 on master.

@jrajahalme
Copy link
Member Author

Apparent CI timeout, K8s 1.11 was killed without any failures, testing again.

@jrajahalme
Copy link
Member Author

test-me-please

@aanm
Copy link
Member

aanm commented Apr 20, 2020

@jrajahalme needs rebase against master so the tests don't timeout

@pchaigno pchaigno added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 21, 2020
@jrajahalme
dns: Log WriteMsgIP details.
5db77d0 
Add detail to WriteMsgIP log messages in hopes to understand why we
sometimes see a lot of these logs.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/dnsproxy-add-udp-logging-detail branch from 7fc8b04 to 5db77d0 Compare April 25, 2020 02:28
@jrajahalme
Copy link
Member Author

test-me-please

@aanm aanm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 27, 2020
@aanm aanm merged commit d07eec5 into master Apr 27, 2020
1.8.0 automation moved this from In progress to Merged Apr 27, 2020
@aanm aanm deleted the pr/jrajahalme/dnsproxy-add-udp-logging-detail branch April 27, 2020 09:21
@vadorovsky vadorovsky mentioned this pull request Apr 29, 2020
Merged
@joestringer joestringer added this to Needs backport from master in 1.7.4 Apr 29, 2020
@joestringer joestringer removed this from Needs backport from master in 1.7.3 Apr 29, 2020
@aanm aanm moved this from Needs backport from master to Backport pending to v1.7 in 1.7.4 May 13, 2020
@aanm aanm moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.4 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raybejjani raybejjani raybejjani approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.4
Backport done to v1.7
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jrajahalme @coveralls @aanm @raybejjani @joestringer @pchaigno @vadorovsky