hubble-proxy: remove explicit binary stripping #11058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
pending-review
kind/cleanup
|
test-me-please EDIT: CI test timeout |
gandro
approved these changes
Apr 20, 2020
rolinh
approved these changes
Apr 20, 2020
michi-covalent
approved these changes
Apr 20, 2020
Since commit 508fee9 ("make: strip symbol tables from all binaries by default") all cilium binaries are stripped by default using Go linker options -s and -w, unless NOSTRIP is set. Thus, don't unconditionally strip the hubble-proxy binary but rely on the global behavior. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/hubble-proxy-strip
branch
from
146db19
to
3e2da7c
Compare
|
test-me-please EDIT: hit #10118 https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/452/ |
|
restart-ginkgo |
|
test-gke |
pchaigno
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 508fee9 ("make: strip symbol tables from all binaries
by default") all cilium binaries are stripped by default using Go linker
options
-sand-w, unlessNOSTRIPis set. Thus, don't unconditionallystrip the
hubble-proxybinary but rely on the global behavior.