Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --container-runtime{,-endpoint} options #11060

Merged
merged 1 commit into from Apr 21, 2020
Merged

Remove deprecated --container-runtime{,-endpoint} options #11060

merged 1 commit into from Apr 21, 2020

Conversation

tklauser
Copy link
Member

These no longer have any effect, were deprecated in 1.7 and announced to
be removed in the upcoming 1.8.

Also remove remains of the --docker command line option which is no
longer supported since commit 532ad9d ("rm pkg/workloads")

@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 20, 2020
@tklauser tklauser requested a review from a team April 20, 2020 12:11
@tklauser tklauser requested review from a team as code owners April 20, 2020 12:11
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 20, 2020
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Apr 20, 2020
@tklauser
Copy link
Member Author

test-me-please

@tklauser tklauser added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Apr 20, 2020
aanm
aanm requested changes Apr 20, 2020
View reviewed changes
Documentation/install/upgrade.rst Outdated Show resolved Hide resolved
@tklauser
Remove deprecated --container-runtime{,-endpoint} options
bc40455 
These no longer have any effect, were deprecated in 1.7 and announced to
be removed in the upcoming 1.8.

Also remove remains of the --docker command line option which is no
longer supported since commit 532ad9d ("rm pkg/workloads")

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/remove-container-runtime-options branch from b163f97 to bc40455 Compare April 20, 2020 12:13
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 46.814% when pulling bc40455 on pr/tklauser/remove-container-runtime-options into 794f5b3 on master.

@tklauser
Copy link
Member Author

tklauser commented Apr 20, 2020 •
edited

test-me-please

EDIT: hit timeout on GKE https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/444/

@tklauser
Copy link
Member Author

test-gke

soumynathan
soumynathan reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@soumynathan soumynathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pchaigno
Copy link
Member

pchaigno commented Apr 21, 2020 •
edited

Got:

Cilium cannot be installed
Expected
    <*errors.errorString | 0xc0002d4e70>: {
        s: "could not find pods in namespace 'cilium' with label 'io.cilium/app=operator': signal: killed",
    }
to be nil

test-gke

@aanm aanm merged commit adbc150 into master Apr 21, 2020
1.8.0 automation moved this from In progress to Merged Apr 21, 2020
@aanm aanm deleted the pr/tklauser/remove-container-runtime-options branch April 21, 2020 20:16
@joestringer joestringer mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumynathan soumynathan soumynathan left review comments

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @pchaigno @aanm @soumynathan