Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update EKS GSG to clarify deployment in ENI vs. overlay mode #11068

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

danwent
Copy link
Contributor

@danwent danwent commented Apr 20, 2020

Signed-off-by: Dan Wendlandt dan@covalent.io

@danwent danwent requested a review from a team as a code owner April 20, 2020 15:29
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 20, 2020
@danwent danwent added the release-note/misc This PR makes changes that have no direct user impact. label Apr 20, 2020
@coveralls
Copy link

coveralls commented Apr 20, 2020

Coverage Status

Coverage increased (+0.007%) to 44.672% when pulling 8934e2d on danwent:eks-overlay-note into 5c0b426 on cilium:master.

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor wording nit.

similar to the behavior of the
`Amazon VPC CNI plugin <https://docs.aws.amazon.com/eks/latest/userguide/pod-networking.html>`_.

Cilium can also run in EKS using an overlay mode that gives pods non-VPC-routable IPs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cilium can also run in EKS using an overlay mode that gives pods non-VPC-routable IPs.
Cilium can alternatively run in EKS using an overlay mode that gives pods non-VPC-routable IPs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Just pushed this change.

Signed-off-by: Dan Wendlandt <dan@covalent.io>
@joestringer joestringer merged commit 6bcbf2d into cilium:master Apr 21, 2020
1.8.0 automation moved this from In progress to Merged Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants