metrics: Do not rely on global HTTP server #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
pending-review
area/metrics
|
test-me-please |
rolinh
approved these changes
Apr 20, 2020
michi-covalent
approved these changes
Apr 20, 2020
aanm
approved these changes
Apr 20, 2020
The global |
vadorovsky
approved these changes
Apr 20, 2020
|
test-me-please |
This moves away from the global Golang HTTP server for serving the metrics for both Hubble and Cilium. Instead, a local instance is created, which allows the two metrics server to run concurrently. Fixes: #11066 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/serve-metrics-on-nondefault-httpserver
branch
from
a15fb54
to
07805df
Compare
|
test-me-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves away from the global Golang HTTP server for serving the metrics for both Hubble and Cilium. Instead, a local instance is created, which allows the two metrics server to run concurrently.
Going forward, there also needs to be a discussion if we really want to have two different metrics server running inside cilium-agent. We either might want to move it out to
hubble-relay(formerlyhubble-proxy) or integrate the Hubble metrics with the Cilium ones.This PR simply sidesteps that discussion by fixing the referenced bug in the simplest way possible.
Fixes: #11066