Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf, xdp: various optimizations for nodeport #11082

Merged
merged 4 commits into from Apr 22, 2020
Merged

Conversation

borkmann
Copy link
Member

See commit msg.

If we do not have prefilter configured, then lets spare the cycles and
also not have it needlessly compiled in.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Allow GRO to operate naturally rather than potentially breaking a TCP pkt
train in the middle of aggregation due to meta data mismatch. This does
not matter at all in case we do not push up the stack, so do not perform
unneeded work for ctx_act_{drop,tx}. Verified that before we had 24 bytes
in skb meta data and afterwards 0 bytes.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Apr 21, 2020
@borkmann borkmann requested review from brb and a team April 21, 2020 15:30
@borkmann borkmann requested a review from a team as a code owner April 21, 2020 15:30
@borkmann borkmann changed the title xdp: various optimizations bpf, xdp: various optimizations for nodeport Apr 21, 2020
Make use of the meta data feature to signal to the skb layer that we've
seen the xdp packet during nodeport handling and that it's a non-service
packet where in tc ingress we can then bypass the entire nodeport processing
(key extraction, CT lookup, rev NAT) since already done from XDP.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@coveralls
Copy link

coveralls commented Apr 21, 2020

Coverage Status

Coverage decreased (-0.002%) to 44.67% when pulling 96802b6 on pr/xdp-follow-ups-2 into 84abbf8 on master.

... which then also shortens cycles on GRO for comparing skbs when
aggregating.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

test-me-please

@borkmann
Copy link
Member Author

test-gke

Copy link
Contributor

@jrfastab jrfastab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@borkmann
Copy link
Member Author

(ci green)

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@borkmann borkmann merged commit 0c1a912 into master Apr 22, 2020
@borkmann borkmann deleted the pr/xdp-follow-ups-2 branch April 22, 2020 00:42
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants