-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Pin Hubble version to v0.5 branch #11121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubble is undergoing some big architectural changes with Cilium 1.8 which will also impact the way it is deployed. Notably, Hubble v0.5 will be the last version of Hubble to support Cilium 1.7. Therefore, the documentation in Cilium 1.7 needs to be updated to point to the v0.5 branch, as the master branch of `github.com/cilium/hubble` will not contain the Hubble stand-alone server Helm charts (required to run Hubble with Cilium 1.7) going forward. The Hubble documentation will need a significant overhaul for the Cilium 1.8 release. However, this is going to be done at a later date and is out of scope for this PR. This PR is soley intended to ensure the Cilium 1.7 documentation will stay functional going forward. Hubble v0.5 is compatible with Cilium 1.8, therefore the `latest` docs are remaining functional as well. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
release-note/misc
This PR makes changes that have no direct user impact.
needs-backport/1.7
labels
Apr 23, 2020
test-docs-please |
rolinh
approved these changes
Apr 23, 2020
tklauser
approved these changes
Apr 23, 2020
michi-covalent
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubble is undergoing some big architectural changes with Cilium 1.8
which will also impact the way it is deployed. Notably, Hubble v0.5
will be the last version of Hubble to support Cilium 1.7.
Therefore, the documentation in Cilium 1.7 needs to be updated to point
to the v0.5 branch, as the master branch of
github.com/cilium/hubble
will not contain the Hubble stand-alone server Helm charts (required
to run Hubble with Cilium 1.7) going forward.
The Hubble documentation will need a significant overhaul for the
Cilium 1.8 release. However, this is going to be done at a later
date and is out of scope for this PR. This PR is solely intended to
ensure the Cilium 1.7 documentation will stay functional going
forward. Hubble v0.5 is compatible with Cilium 1.8, therefore
the
latest
docs are remaining functional as well.