Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Pin Hubble version to v0.5 branch #11121

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

gandro
Copy link
Member

@gandro gandro commented Apr 23, 2020

Hubble is undergoing some big architectural changes with Cilium 1.8
which will also impact the way it is deployed. Notably, Hubble v0.5
will be the last version of Hubble to support Cilium 1.7.

Therefore, the documentation in Cilium 1.7 needs to be updated to point
to the v0.5 branch, as the master branch of github.com/cilium/hubble
will not contain the Hubble stand-alone server Helm charts (required
to run Hubble with Cilium 1.7) going forward.

The Hubble documentation will need a significant overhaul for the
Cilium 1.8 release. However, this is going to be done at a later
date and is out of scope for this PR. This PR is solely intended to
ensure the Cilium 1.7 documentation will stay functional going
forward. Hubble v0.5 is compatible with Cilium 1.8, therefore
the latest docs are remaining functional as well.

Hubble is undergoing some big architectural changes with Cilium 1.8
which will also impact the way it is deployed. Notably, Hubble v0.5
will be the last version of Hubble to support Cilium 1.7.

Therefore, the documentation in Cilium 1.7 needs to be updated to point
to the v0.5 branch, as the master branch of `github.com/cilium/hubble`
will not contain the Hubble stand-alone server Helm charts (required
to run Hubble with Cilium 1.7) going forward.

The Hubble documentation will need a significant overhaul for the
Cilium 1.8 release. However, this is going to be done at a later
date and is out of scope for this PR. This PR is soley intended to
ensure the Cilium 1.7 documentation will stay functional going
forward. Hubble v0.5 is compatible with Cilium 1.8, therefore
the `latest` docs are remaining functional as well.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.7 labels Apr 23, 2020
@gandro gandro requested a review from a team as a code owner April 23, 2020 11:07
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.3 Apr 23, 2020
@gandro
Copy link
Member Author

gandro commented Apr 23, 2020

test-docs-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 44.655% when pulling 2bc0bad on pr/gandro/pin-release-hubble-version into beea9ea on master.

@joestringer joestringer merged commit 1cb4020 into master Apr 23, 2020
1.8.0 automation moved this from In progress to Merged Apr 23, 2020
@joestringer joestringer deleted the pr/gandro/pin-release-hubble-version branch April 23, 2020 21:27
@joestringer joestringer added this to Needs backport from master in 1.7.4 Apr 29, 2020
@joestringer joestringer removed this from Needs backport from master in 1.7.3 Apr 29, 2020
@aanm aanm moved this from Needs backport from master to Backport pending to v1.7 in 1.7.4 May 13, 2020
@aanm aanm moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.4 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.4
Backport done to v1.7
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

8 participants