hubble-cli: Mount /var/run/cilium as a directory #11129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been hitting an issue with mounting /var/run/cilium/hubble.sock as the Socket type where sometimes /var/run/cilium/hubble.sock gets created as a directory. To reproduce this behavior on minikube: - Deploy Cilium with the Hubble CLI enabled and wait for the hubble-cli to become ready. Verify that hubble.sock is a UNIX domain socket. - Set `enable-hubble` to "false" in cilium-config configmap and restart Cilium. - Now /var/run/cilium/hubble.sock is a directory. It seems like somehow hubble-cli creates the directory when Cilium deletes hubble.sock. Because of this directory Cilium fails to start Hubble server the next time `enable-hubble` gets set to `true`. With this PR /var/run/cilium directory gets mounted as a directory instead. I manually verified this fixes the issue. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
|
Please set the appropriate release note label. |
michi-covalent
added
the
release-note/misc
aanm
approved these changes
Apr 24, 2020
|
test-me-please |
gandro
approved these changes
Apr 24, 2020
|
@gandro try adding the hubble socket path as a volume mount for cilium with type socket to see if it helps. |
|
test-me-please |
|
test-with-kernel |
|
Another good reason for mounting the directory is avoid issues with socket file actually getting deleted/re-created. |
|
test-gke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hitting an issue with mounting /var/run/cilium/hubble.sock as
the Socket type where sometimes /var/run/cilium/hubble.sock gets created
as a directory. To reproduce this behavior on minikube:
to become ready. Verify that hubble.sock is a UNIX domain socket.
enable-hubbleto "false" in cilium-config configmap and restartCilium.
hubble-cli creates the directory when Cilium deletes hubble.sock.
Because of this directory Cilium fails to start Hubble server the next
time
enable-hubblegets set totrue. With this PR /var/run/ciliumdirectory gets mounted as a directory instead. I manually verified this
fixes the issue.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com