CI: Restart all kube-system pods in GKE #11136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raybejjani
added
wip
area/CI
|
test-gke K8sDemosTest.* |
|
test-gke |
nebril
requested changes
Apr 24, 2020
test/k8sT/assertionHelpers.go
Outdated
| case helpers.CIIntegrationGKE: | ||
| By("Restarting all kube-system pods") | ||
| if res := vm.DeleteResource("pod", fmt.Sprintf("-n %s --all", helpers.KubeSystemNamespace)); !res.WasSuccessful() { | ||
| log.Warningf("Unable to delete DNS pods: %s", res.OutputPrettyPrint()) |
There was a problem hiding this comment.
I think this msg should not be DNS-specific.
test/k8sT/assertionHelpers.go
Outdated
| @@ -138,6 +143,9 @@ func DeployCiliumOptionsAndDNS(vm *helpers.Kubectl, ciliumFilename string, optio | |||
| ExpectCiliumReady(vm) | |||
| ExpectCiliumOperatorReady(vm) | |||
| ExpectKubeDNSReady(vm) | |||
|
|
|||
| err := vm.WaitforPods(helpers.KubeSystemNamespace, "", longTimeout) | |||
There was a problem hiding this comment.
Shouldn't this block be done only if we are running in GKE?
There was a problem hiding this comment.
I figured it was harmless anyway. I can put it in an if if you'd like
|
test-gke |
Some of these pods are scheduled before cilium and are never managed. They still have issues, however, and some are cricital to the cluster's health. Signed-off-by: Ray Bejjani <ray@isovalent.com>
raybejjani
force-pushed
the
ci-restart-k8s-pods
branch
from
fb2c6ee
to
10e71cd
Compare
|
test-gke (passed https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/684/) |
nebril
approved these changes
Apr 27, 2020
|
test-gke (passed) |
|
test-me-please |
nebril
approved these changes
Apr 28, 2020
|
test-gke |
1 similar comment
|
test-gke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these pods are scheduled before cilium and are never managed.
They still have issues, however, and some are cricital to the cluster's
health.