Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add documentation section about Hubble internals #11139

Merged
merged 1 commit into from Apr 24, 2020
Merged

doc: add documentation section about Hubble internals #11139

merged 1 commit into from Apr 24, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Apr 24, 2020

No description provided.

@rolinh rolinh added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay labels Apr 24, 2020
@rolinh rolinh requested a review from a team as a code owner April 24, 2020 14:28
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 24, 2020
tgraf
tgraf requested changes Apr 24, 2020
View reviewed changes
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
@rolinh rolinh force-pushed the pr/rolinh/doc-hubble-internals branch from 6127598 to a102b2f Compare April 24, 2020 14:50
@rolinh rolinh requested a review from tgraf April 24, 2020 14:51
@coveralls
Copy link

coveralls commented Apr 24, 2020 •
edited

Coverage Status

Coverage decreased (-0.04%) to 44.728% when pulling 56e87ca on pr/rolinh/doc-hubble-internals into fa336bd on master.

michi-covalent
michi-covalent approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! one nit

Documentation/hubble.rst Outdated Show resolved Hide resolved
@rolinh rolinh force-pushed the pr/rolinh/doc-hubble-internals branch from a102b2f to 46e38b7 Compare April 24, 2020 17:48
glibsm
glibsm reviewed Apr 24, 2020
View reviewed changes
Documentation/hubble.rst Outdated Show resolved Hide resolved
@rolinh rolinh force-pushed the pr/rolinh/doc-hubble-internals branch from 46e38b7 to 1f008b8 Compare April 24, 2020 18:46
joestringer
joestringer requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A few nits below.

Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
Documentation/hubble.rst Outdated Show resolved Hide resolved
@rolinh rolinh force-pushed the pr/rolinh/doc-hubble-internals branch from 1f008b8 to 97e802c Compare April 24, 2020 19:53
@rolinh rolinh requested a review from joestringer April 24, 2020 19:55
joestringer
joestringer approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one remaining nit.

Documentation/hubble.rst Outdated Show resolved Hide resolved
@rolinh
doc: add documentation section about Hubble internals
56e87ca 
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/doc-hubble-internals branch from 97e802c to 56e87ca Compare April 24, 2020 20:28
@tgraf tgraf merged commit ad2b169 into master Apr 24, 2020
1.8.0 automation moved this from In progress to Merged Apr 24, 2020
@tgraf tgraf deleted the pr/rolinh/doc-hubble-internals branch April 24, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glibsm glibsm glibsm left review comments

@michi-covalent michi-covalent michi-covalent approved these changes

@joestringer joestringer joestringer approved these changes

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rolinh @coveralls @glibsm @joestringer @tgraf @michi-covalent