Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/hubble: Fully remove Cilium installation #11141

Merged
merged 1 commit into from Apr 26, 2020
Merged

ci/hubble: Fully remove Cilium installation #11141

merged 1 commit into from Apr 26, 2020

Conversation

gandro
Copy link
Member

@gandro gandro commented Apr 24, 2020

We are generating the Cilium YAML which contains more pods than just the
Cilium DaemonSet (the hubble-cli DaemonSet in this case). Therefore, we
should also remove everything we generate.

@gandro
ci/hubble: Fully remove Cilium installation
d108766 
We are generating the Cilium YAML which contains more pods than just the
Cilium DaemonSet (the `hubble-cli` DaemonSet in this case). Therefore, we
should also remove everything we generate.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Apr 24, 2020
@gandro gandro requested a review from a team as a code owner April 24, 2020 15:52
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 24, 2020
@gandro
Copy link
Member Author

gandro commented Apr 24, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 44.762% when pulling d108766 on pr/gandro/ci-hubble-delete-all into 89b622c on master.

@borkmann borkmann mentioned this pull request Apr 24, 2020
Merged
nebril
nebril approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeleteCiliumDS also waits for all Cilium pods to be terminated, but I think we are good here since next line does just that.

@gandro
Copy link
Member Author

gandro commented Apr 24, 2020

test-gke

1 similar comment
@gandro
Copy link
Member Author

gandro commented Apr 25, 2020

test-gke

@pchaigno pchaigno merged commit 93bb592 into master Apr 26, 2020
1.8.0 automation moved this from In progress to Merged Apr 26, 2020
@pchaigno pchaigno deleted the pr/gandro/ci-hubble-delete-all branch April 26, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@raybejjani raybejjani raybejjani approved these changes

@nebril nebril nebril approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gandro @coveralls @errordeveloper @raybejjani @nebril @pchaigno