Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: minor typo fix CRD allocator guide #11143

Merged
merged 1 commit into from Apr 24, 2020

Conversation

mqasimsarfraz
Copy link

@mqasimsarfraz mqasimsarfraz commented Apr 24, 2020

Signed-off-by: Qasim Sarfraz qasim.sarfraz@esailors.de

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Signed-off-by: Qasim Sarfraz <qasim.sarfraz@esailors.de>
@mqasimsarfraz mqasimsarfraz requested a review from a team as a code owner April 24, 2020 16:35
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 24, 2020
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Apr 24, 2020
@joestringer
Copy link
Member

@mqasimsarfraz thanks for the submission! I'll merge soon.

FYI the text in the issue description is for you to look at and check off. In particular please remove the last section since there's no need for release-note text for this typo fix.

@joestringer joestringer merged commit fa336bd into cilium:master Apr 24, 2020
1.8.0 automation moved this from In progress to Merged Apr 24, 2020
@mqasimsarfraz
Copy link
Author

@joestringer thanks, I will keep that in mind for my next PR. ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants