Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: Initialize CRD version #11156

Merged
merged 1 commit into from Apr 25, 2020
Merged

k8s: Initialize CRD version #11156

merged 1 commit into from Apr 25, 2020

Conversation

jrajahalme
Copy link
Member

Initialize CRD version so that we'll detect when CRDs must be
updated. When uninitialized, the version ("0.0.0") is always lower
than the one in the cluster, so we never update CRDs.

Fixes: #11077
Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme
k8s: Initialize CRD version
23893c2 
Initialize CRD version so that we'll detect when CRDs must be
updated. When uninitialized, the version ("0.0.0") is always lower
than the one in the cluster, so we never update CRDs.

Fixes: #11077
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/bug This is a bug in the Cilium logic. pending-review sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. labels Apr 25, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner April 25, 2020 02:23
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 25, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 44.771% when pulling 23893c2 on pr/jrajahalme/k8s-fix-version-check into 3c44ae5 on master.

aanm
aanm approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@aanm aanm merged commit 24c73ac into master Apr 25, 2020
1.8.0 automation moved this from In progress to Merged Apr 25, 2020
@aanm aanm deleted the pr/jrajahalme/k8s-fix-version-check branch April 25, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrajahalme @coveralls @aanm