RenderTemplateToFile writes file to node #11160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit e756684f0bce7b2a54869310433b0523ba45445b does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
@David0922 please follow the instructions provided here #11160 (comment) the commit itself does not contain a sign-off message. |
Signed-off-by: David Chen <yudechen@google.com>
David0922
force-pushed
the
RenderTemplateToFile
branch
from
e756684
to
dd325d6
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
@nebril could you please take a look? thanks! |
|
test-me-please |
nebril
approved these changes
Apr 28, 2020
|
test-gke |
|
test-with-kernel |
1 similar comment
|
test-with-kernel |
aanm
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderTemplateToFile saved the file to the host machine which was not ideal because it relied on NFS to sync the file it generated to the VM where tests were run. This patch fixes this by saving the file directly to the VM via ssh.
Signed-off-by: David Chen yudechen@google.com