Add deepcopy generator checker #11165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/cleanup
|
test-me-please |
gandro
force-pushed
the
pr/add-generator-checker
branch
from
9ba4d30
to
6200951
Compare
|
test-me-please |
christarazi
approved these changes
Apr 27, 2020
k8s deepcopy generator can have multiple groups for the same version passed as a parameter. To speed up the code generation we can merge all of them together. The amount of time decreased from 50s to 16s. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/add-generator-checker
branch
from
6200951
to
cd62ba8
Compare
The parent `StatusResponse` struct requires it to perform a deep copy. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
To avoid code from being merged without being regenerated, this commit adds a checker, that will only run in the CI, to verify if there is code ungenerated. Signed-off-by: André Martins <andre@cilium.io>
gandro
force-pushed
the
pr/add-generator-checker
branch
from
cd62ba8
to
98728bb
Compare
|
test-me-please |
qmonnet
approved these changes
Apr 28, 2020
|
@qmonnet that is correct. I didn't had a fixes because it because of multiple commits and this is always happening. |
|
Multiple GKE failures, all looking like known flakes: test-gke |
|
@qmonnet GKE is not marked as "Required" for a PR to be merged. |
|
|
nebril
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid code from being merged without being regenerated, this commit adds a checker, that will only run in the CI, to verify if there is code ungenerated.