Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Improve ability to run tests on non-CI clusters #11167

Merged
merged 2 commits into from Apr 29, 2020
Merged

CI: Improve ability to run tests on non-CI clusters #11167

merged 2 commits into from Apr 29, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 27, 2020 •
edited

The current tests assume that certain operations are performed in scripts during cluster selection time. This makes it harder to run individual tests on a custom cluster instead of using the standard CI clusters.

This PR achieves two things:

  • Deletes all non-essential namespaces (kube-system, default, cilium, ...) before the first test
  • Decouples node-labeling from node naming

@tgraf tgraf added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Apr 27, 2020
@tgraf tgraf requested a review from a team as a code owner April 27, 2020 10:15
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 27, 2020
@tgraf tgraf marked this pull request as draft April 27, 2020 10:16
@tgraf
Copy link
Member Author

tgraf commented Apr 27, 2020

test-me-please

@coveralls
Copy link

coveralls commented Apr 27, 2020 •
edited

Coverage Status

Coverage increased (+0.001%) to 44.805% when pulling d8b916f on pr/tgraf/ci-remove-old-resources into e7d4f5c on master.

@tgraf tgraf force-pushed the pr/tgraf/ci-remove-old-resources branch from c9ed4c2 to e325008 Compare April 27, 2020 11:10
@tgraf
Copy link
Member Author

tgraf commented Apr 27, 2020

test-me-please

@tgraf tgraf mentioned this pull request Apr 27, 2020
Merged
@tgraf
test: Delete all non-essential namespaces before initial test
ce1bf87 
This deletes any leftover namespaces that may exist from previously ran
tests.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/ci-remove-old-resources branch from e325008 to d8b916f Compare April 27, 2020 23:30
@tgraf
Copy link
Member Author

tgraf commented Apr 27, 2020

test-me-please

@tgraf
Copy link
Member Author

tgraf commented Apr 28, 2020

restart-ginkgo

@tgraf tgraf added ci/flake This is a known failure that occurs in the tree. Please investigate me! pending-review labels Apr 28, 2020
@tgraf tgraf marked this pull request as ready for review April 28, 2020 07:07
@tgraf tgraf changed the title Improve CI test bootstrapping CI: Improve ability to run tests on non-CI clusters Apr 28, 2020
nebril
nebril requested changes Apr 28, 2020
View reviewed changes
test/helpers/kubectl.go Outdated Show resolved Hide resolved
@tgraf
test: Decouple node labeling from node names
2ebb995 
Use a generic labelling iterator instead of assuming certain naming of
nodes. Also, fail the test if the labeling can't be done.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/ci-remove-old-resources branch from d8b916f to 2ebb995 Compare April 29, 2020 08:17
@tgraf tgraf merged commit 014fd8e into master Apr 29, 2020
1.8.0 automation moved this from In progress to Merged Apr 29, 2020
@tgraf tgraf deleted the pr/tgraf/ci-remove-old-resources branch April 29, 2020 08:17
@b3a-dev b3a-dev added this to Fixed / Done in CI Force May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril requested changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
CI Force
  
Fixed / Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgraf @coveralls @nebril