Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/k8s: remove unused consts and variables #11177

Merged
merged 1 commit into from Apr 28, 2020
Merged

pkg/k8s: remove unused consts and variables #11177

merged 1 commit into from Apr 28, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 27, 2020

Some consts and variables are no longer being by the refactoring of
f0049da, for this reason we can remove them.

Fixes: f0049da ("pkg/k8s: fix all structural issues with CNP validation")
Signed-off-by: André Martins andre@cilium.io

@aanm
pkg/k8s: remove unused consts and variables
35ac886 
Some consts and variables are no longer being by the refactoring of
f0049da, for this reason we can remove them.

Fixes: f0049da ("pkg/k8s: fix all structural issues with CNP validation")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 27, 2020
@aanm aanm requested a review from a team as a code owner April 27, 2020 16:11
@aanm aanm requested a review from a team April 27, 2020 16:11
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 27, 2020
@aanm
Copy link
Member Author

aanm commented Apr 27, 2020

test-me-please

1 similar comment
@aanm
Copy link
Member Author

aanm commented Apr 27, 2020

test-me-please

@aanm aanm added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. pending-review and removed pending-review labels Apr 27, 2020
@qmonnet qmonnet merged commit 904cae6 into master Apr 28, 2020
1.8.0 automation moved this from In progress to Merged Apr 28, 2020
@qmonnet qmonnet deleted the pr/fix-unused-fields branch April 28, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanm @joestringer @qmonnet