test: Fix skipping of NodePort tests #11186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids the following errors when running with the net-next kernel and KUBEPROXY=1: Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan Tests NodePort Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with vxlan Tests HostPort Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests HostPort Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests with MetalLB Connectivity to endpoint via LB Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing and DSR Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with XDP, direct routing and Hybrid Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with XDP, direct routing and DSR Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with TC, direct routing and Hybrid Suite-k8s-1.11.K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with TC, direct routing and DSR Signed-off-by: Paul Chaignon <paul@cilium.io>
Test 'K8sServicesTest - Tests GH#10983' requires the third node to exist, but isn't skipped if it doesn't exist. This commit fixes it. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI-improvement
|
test-me-please |
nebril
approved these changes
Apr 28, 2020
|
test-with-kernel |
aanm
added
area/CI-improvement
qmonnet
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issues were found while running tests locally with option combinations that are not tested in our CI pipelines.
The first commit skips BPF-based NodePort tests when running with kube-proxy enabled (found while running
NETNEXT=1 K8S_VERSION=1.11 ginkgo --focus="K8s*").The second commit skips one test that uses the third-node, the node without Cilium, when that node isn't available (found while running
KUBEPROXY=0 NETNEXT=1 K8S_VERSION=1.11 ginkgo --focus="K8s*").Test results with
KUBEPROXY=1and the net-next kernel can be observed at #11118./cc @brb