hubble-relay: add Dockerfile and make target to build hubble-relay image #11192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
kind/enhancement
rolinh
force-pushed
the
pr/rolinh/hubble-relay-docker
branch
from
9cbaa32
to
1b6326d
Compare
michi-covalent
approved these changes
Apr 28, 2020
|
test-me-please |
aanm
requested changes
Apr 29, 2020
There was a problem hiding this comment.
Please update the release process documentation stating that this image also needs to be taken care of when doing a release
cilium/Documentation/contributing/release/stable.rst
Lines 179 to 180 in 3ca38b3
rolinh
commented
Apr 29, 2020
rolinh
force-pushed
the
pr/rolinh/hubble-relay-docker
branch
from
1b6326d
to
bd0c040
Compare
|
gandro
approved these changes
Apr 29, 2020
|
test-me-please |
tklauser
reviewed
Apr 29, 2020
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
The "${CONTAINER_ENGINE}" variable should be used instead of "docker"
within make targets. This commits fixes 2 instances where "docker" was
used instead of the variable.
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/hubble-relay-docker
branch
from
bd0c040
to
06e19ef
Compare
|
test-me-please |
tklauser
approved these changes
Apr 29, 2020
michi-covalent
added a commit
that referenced
this pull request
Apr 29, 2020
This PR adds a new helm chart for Hubble Relay deployment/service. A few things to note: - Each Hubble Relay pod must be scheduled on a node with Cilium running. Hubble Relay connects to the hubble unix domain socket to retrive peer information. - For now the readiness/liveness probes simply checks if the gRPC port is open since Hubble Relay doesn't have the status command yet. Closes: #11226 Ref: #11192 #10648 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
aanm
approved these changes
Apr 30, 2020
qmonnet
approved these changes
Apr 30, 2020
michi-covalent
added a commit
that referenced
this pull request
Apr 30, 2020
This PR adds a new helm chart for Hubble Relay deployment/service. A few things to note: - Each Hubble Relay pod must be scheduled on a node with Cilium running. Hubble Relay connects to the hubble unix domain socket to retrive peer information. - For now the readiness/liveness probes simply checks if the gRPC port is open since Hubble Relay doesn't have the status command yet. Closes: #11226 Ref: #11192 #10648 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
qmonnet
pushed a commit
that referenced
this pull request
May 2, 2020
This PR adds a new helm chart for Hubble Relay deployment/service. A few things to note: - Each Hubble Relay pod must be scheduled on a node with Cilium running. Hubble Relay connects to the hubble unix domain socket to retrive peer information. - For now the readiness/liveness probes simply checks if the gRPC port is open since Hubble Relay doesn't have the status command yet. Closes: #11226 Ref: #11192 #10648 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.