Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Overwrite existing taint when labeling nodes with NoSchedule #11221

Merged
merged 1 commit into from Apr 29, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 29, 2020

Martynas reported that the following error occurs:

      unable label nodes: unable to taint node with 'kubectl taint nodes k8s3 key=value:NoSchedule': Exitcode: 1
      Stdout:
      Stderr:
         error: node k8s3 already has key taint(s) with same effect(s) and --overwrite is false

.. when the option --cilium.provision=false is used

Fixes: 014fd8e ("test: Decouple node labeling from node names")

Martynas reported that the following error occurs:
```
      unable label nodes: unable to taint node with 'kubectl taint nodes k8s3 key=value:NoSchedule': Exitcode: 1
      Stdout:
      Stderr:
         error: node k8s3 already has key taint(s) with same effect(s) and --overwrite is false
```

.. when the option `--cilium.provision=false` is used

Fixes: 014fd8e ("test: Decouple node labeling from node names")
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. kind/bug/CI This is a bug in the testing code. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Apr 29, 2020
@tgraf tgraf requested a review from a team as a code owner April 29, 2020 13:28
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 29, 2020
@tgraf tgraf added the release-note/misc This PR makes changes that have no direct user impact. label Apr 29, 2020
@tgraf tgraf removed the kind/bug This is a bug in the Cilium logic. label Apr 29, 2020
@tgraf
Copy link
Member Author

tgraf commented Apr 29, 2020

test-me-please

Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brb
Copy link
Member

brb commented Apr 29, 2020

Tested locally - fixes the issue, ta!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 44.608% when pulling 9f8b105 on pr/tgraf/ci-add-overwrite-to-noschedule-taint into 2950ea4 on master.

@tgraf tgraf merged commit 97f8299 into master Apr 29, 2020
1.8.0 automation moved this from In progress to Merged Apr 29, 2020
@tgraf tgraf deleted the pr/tgraf/ci-add-overwrite-to-noschedule-taint branch April 29, 2020 16:59
@b3a-dev b3a-dev added this to Fixed / Done in CI Force May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/flake This is a known failure that occurs in the tree. Please investigate me! kind/bug/CI This is a bug in the testing code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
CI Force
  
Fixed / Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants