New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Overwrite existing taint when labeling nodes with NoSchedule #11221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martynas reported that the following error occurs: ``` unable label nodes: unable to taint node with 'kubectl taint nodes k8s3 key=value:NoSchedule': Exitcode: 1 Stdout: Stderr: error: node k8s3 already has key taint(s) with same effect(s) and --overwrite is false ``` .. when the option `--cilium.provision=false` is used Fixes: 014fd8e ("test: Decouple node labeling from node names") Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
kind/bug
This is a bug in the Cilium logic.
kind/bug/CI
This is a bug in the testing code.
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
labels
Apr 29, 2020
Please set the appropriate release note label. |
3 similar comments
Please set the appropriate release note label. |
Please set the appropriate release note label. |
Please set the appropriate release note label. |
tgraf
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Apr 29, 2020
test-me-please |
brb
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Tested locally - fixes the issue, ta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
kind/bug/CI
This is a bug in the testing code.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Martynas reported that the following error occurs:
.. when the option
--cilium.provision=false
is usedFixes: 014fd8e ("test: Decouple node labeling from node names")