Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubble: Change uint64 -> uint32 in getters interfaces #11242

Merged
merged 1 commit into from May 1, 2020

Conversation

matej-g
Copy link
Contributor

@matej-g matej-g commented Apr 29, 2020

As identity and endpoint ID are considered to be uint32 after #11161 has been merge, this PR changes their type in getters interfaces accordingly and adjusts them to be uint32 as well. Includes related changes in parsers, daemon as well as tests.

Fixes: #11241

Signed-off-by: Matej Gera matejgera@gmail.com

hubble: Change uint64 -> uint32 in getters interfaces

Signed-off-by: Matej Gera <matejgera@gmail.com>
@matej-g matej-g requested review from a team April 29, 2020 21:46
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Apr 29, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 44.643% when pulling 9b657b2 on matej-g:update-uint-getters into 97f8299 on cilium:master.

@rolinh rolinh added sig/hubble Impacts hubble server or relay kind/cleanup This includes no functional changes. labels Apr 30, 2020
@aanm
Copy link
Member

aanm commented Apr 30, 2020

test-me-please

@aanm aanm merged commit 60c650b into cilium:master May 1, 2020
1.8.0 automation moved this from In progress to Merged May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

hubble: change uint64 -> uint32 in getters interfaces
5 participants