Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update Go version in .travis.yml directly #11252

Merged
merged 1 commit into from Apr 30, 2020
Merged

CI: update Go version in .travis.yml directly #11252

merged 1 commit into from Apr 30, 2020

Conversation

tklauser
Copy link
Member

There's no need to keep a template file, the Go version can be updated
in .travis.yml directly. This avoids the two files getting out of sync
if modifications are only made to .travis.yml, but not .travis.yml.tmpl.

@tklauser
CI: update Go version in .travis.yml directly
ec8e6f7 
There's no need to keep a template file, the Go version can be updated
in .travis.yml directly. This avoids the two files getting out of sync
if modifications are only made to .travis.yml, but not .travis.yml.tmpl.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Apr 30, 2020
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

3 similar comments
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 30, 2020
@tklauser tklauser added pending-review release-note/misc This PR makes changes that have no direct user impact. and removed pending-review labels Apr 30, 2020
@tklauser tklauser marked this pull request as ready for review April 30, 2020 10:29
@tklauser tklauser requested a review from a team as a code owner April 30, 2020 10:29
@tklauser
Copy link
Member Author

test-me-please

pchaigno
pchaigno approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 44.631% when pulling ec8e6f7 on pr/tklauser/travis-config-no-template into 4e17dfe on master.

@qmonnet
Copy link
Member

qmonnet commented Apr 30, 2020 •
edited

There seems to be a known flake for the test that failed, let's re-run just that one.

test-focus K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests with MetalLB Connectivity to endpoint via LB

@qmonnet qmonnet merged commit c6fa3f9 into master Apr 30, 2020
1.8.0 automation moved this from In progress to Merged Apr 30, 2020
@qmonnet qmonnet deleted the pr/tklauser/travis-config-no-template branch April 30, 2020 16:17
@b3a-dev b3a-dev added this to Fixed / Done in CI Force May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
CI Force
  
Fixed / Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tklauser @coveralls @qmonnet @pchaigno