Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: Fix operator flags #11270

Merged
merged 1 commit into from Apr 30, 2020
Merged

operator: Fix operator flags #11270

merged 1 commit into from Apr 30, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 30, 2020

The operator-specific flags were not populated

Fixes: 588f835 ("operator: split operator-only options into separate package")

@tgraf
operator: Fix operator flags
adb78fb 
The operator specific flags were not populated

Fixes: 588f835 ("operator: split operator-only options into separate package")
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact. labels Apr 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 30, 2020
@tgraf tgraf requested a review from tklauser April 30, 2020 21:26
@tgraf
Copy link
Member Author

tgraf commented Apr 30, 2020

test-me-please

tklauser
tklauser approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. Thanks for catching it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 44.624% when pulling adb78fb on pr/tgraf/fix-operator-flags into 462da1d on master.

@tgraf tgraf mentioned this pull request Apr 30, 2020
Merged
@joestringer
Copy link
Member

joestringer commented Apr 30, 2020 •
edited

Hit #11213, also #11127

@joestringer
Copy link
Member

Fix looks clear, CI flakes seem irrelevant. Good to merge.

@joestringer joestringer merged commit ba3a74b into master Apr 30, 2020
1.8.0 automation moved this from In progress to Merged Apr 30, 2020
@joestringer joestringer deleted the pr/tgraf/fix-operator-flags branch April 30, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgraf @coveralls @joestringer @tklauser