Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Update hubble-ui chart #11273

Merged
merged 1 commit into from May 6, 2020
Merged

helm: Update hubble-ui chart #11273

merged 1 commit into from May 6, 2020

Conversation

michi-covalent
Copy link
Contributor

  • Use v0.5.0 tag by default instead of latest.
  • Rely on requirements.yaml to enable the chart instead of guarding
    individual templates.

Ref: https://github.com/cilium/hubble-ui/releases

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent michi-covalent added release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay area/helm Impacts helm charts and user deployment experience labels Apr 30, 2020
@michi-covalent michi-covalent requested a review from a team April 30, 2020 23:12
@coveralls
Copy link

coveralls commented Apr 30, 2020

Coverage Status

Coverage increased (+0.004%) to 42.557% when pulling 05276e4 on pr/michi/uiversion into a7f8fc8 on master.

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care of this!

install/kubernetes/cilium/charts/hubble-ui/values.yaml Outdated Show resolved Hide resolved
@gandro
Copy link
Member

gandro commented May 1, 2020

test-me-please

@michi-covalent
Copy link
Contributor Author

change the default image pull policy to IfNotPresent.

@michi-covalent
Copy link
Contributor Author

test-me-please

1 similar comment
@gandro
Copy link
Member

gandro commented May 4, 2020

test-me-please

@tgraf
Copy link
Member

tgraf commented May 4, 2020

Unit tests hit: #11289

Restarting

@michi-covalent
Copy link
Contributor Author

test-me-please

@gandro gandro added this to In progress (1.8) in Hubble server May 5, 2020
@gandro
Copy link
Member

gandro commented May 6, 2020

test-me-please

@gandro gandro added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 6, 2020
- Use v0.5.0 tag by default instead of latest.
- Set the default image pull policy to IfNotPresent.
- Rely on requirements.yaml to enable the chart instead of guarding
  individual templates.

Ref: https://github.com/cilium/hubble-ui/releases

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@joestringer joestringer merged commit 3c25373 into master May 6, 2020
Hubble server automation moved this from In progress (1.8) to Done May 6, 2020
@joestringer joestringer deleted the pr/michi/uiversion branch May 6, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
Hubble server
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants