cli: add completion support for fish shell #11284
Conversation
|
Commits 21640e8ae428cace00a4931e2c3d35ef881595ee, 4c957959d84135f9c04ef0ff3d85e87f2cb16233 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
Please set the appropriate release note label. |
1 similar comment
|
Please set the appropriate release note label. |
aanm
added
the
release-note/minor
Recently, fish completion is supported in cobra v1.0.0. It would be nice to leverage this feature in cilium.feature/cilium-fish Fixes: cilium#11283 Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras
force-pushed
the
feature/cilium-fish
branch
from
4c95795
to
6aed9b7
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
test-me-please |
| @@ -62,7 +62,7 @@ func init() { | |||
| flags.StringP("host", "H", "", "URI to server-side API") | |||
| viper.BindPFlags(flags) | |||
| rootCmd.AddCommand(newCmdCompletion(os.Stdout)) | |||
| rootCmd.SetOut(os.Stderr) | |||
| rootCmd.SetOut(os.Stdout) | |||
There was a problem hiding this comment.
Is this change intentional? I wonder if it might be the cause for the CI failure?
There was a problem hiding this comment.
This change is required as internally _cilium _complete command will be called, and it's using the stdout for showing completion options.
I just checked the failure, seems like we are expecting help output in stderr. Let me see if there is easy way to fix this.
This commit is to update the cli test cases for help command Originally, help command output is printing to stderr instead of stdout. This commit might be reverted if it's not agreed by maintainer Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras
force-pushed
the
feature/cilium-fish
branch
from
15eeb7b
to
04c43c7
Compare
|
test-me-please |
1 similar comment
|
test-me-please |
Fixes: #11283