Makefile: Move bpf 'build_all' to ci-precheck target #11291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extra step takes quite a bit of time. To streamline `make` for most development use cases, move it out from the main precheck into a ci-precheck that will always be run by the CI before PRs are merged. Developers can still run the target manually if they're actively developing in the BPF area. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
the
release-note/misc
|
test-me-please |
aanm
approved these changes
May 1, 2020
|
Yup, look for |
errordeveloper
approved these changes
May 1, 2020
qmonnet
approved these changes
May 1, 2020
|
Passed regular CI, GKE not required. Multiple reviews from codeowners. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra step takes quite a bit of time (~45s locally for me). To streamline
makefor most development use cases, move it out from the main precheck into a ci-precheck that will always be run by the CI before PRs are merged. Developers can still run the target manually if they're actively developing in the BPF area.CC: @errordeveloper
CC: @aanm