helm: Add service account annotations for all charts #11304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
sayboras
force-pushed
the
feature/sa-annotations
branch
4 times, most recently
from
ee4862b
to
4c87bf5
Compare
tklauser
added
the
release-note/misc
sayboras
force-pushed
the
feature/sa-annotations
branch
from
4c87bf5
to
e96e0d0
Compare
sayboras
force-pushed
the
feature/sa-annotations
branch
from
e96e0d0
to
4beca72
Compare
|
test-me-please |
sayboras
force-pushed
the
feature/sa-annotations
branch
from
4beca72
to
7d8000e
Compare
|
test-me-please |
In order to use AWS EKS IAM roles for service account, we must annotate service account with IAM role. More details can be found here https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-technical-overview.html Fixes: cilium#11303 Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras
force-pushed
the
feature/sa-annotations
branch
from
7d8000e
to
8356b0f
Compare
aanm
approved these changes
May 5, 2020
|
test-me-please |
errordeveloper
approved these changes
May 5, 2020
There was a problem hiding this comment.
@sayboras thanks for the contribution, this looks good to me :)
joestringer
approved these changes
May 5, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use AWS EKS IAM roles for service account, we must annotate
service account with IAM role. More details can be found here
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-technical-overview.html
Fixes: #11303