Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slimmer protobuf definitions on k8s structures #11326

Merged
merged 4 commits into from
May 6, 2020
Merged

Use slimmer protobuf definitions on k8s structures #11326

merged 4 commits into from
May 6, 2020

Commits on May 6, 2020

  1. api/v1: move protc-gen* to tools/ 

    Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed May 6, 2020
    Configuration menu
    Copy the full SHA
    6355779 View commit details
    Browse the repository at this point in the history

  2. types/slim: add slim packages for k8s structures 

    With these slimmer structures Cilium will only unmarshal the fields
that it uses as opposed to unmarshal all fields and later on ignore the
unused fields.

For now, only Pod will be added as a PoC, later on all other k8s
structures will have a similar change.

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed May 6, 2020
    Configuration menu
    Copy the full SHA
    c4f67fb View commit details
    Browse the repository at this point in the history

  3. Use NamespaceNameGetter interface instead of metav1.Object 

    Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed May 6, 2020
    Configuration menu
    Copy the full SHA
    7b76557 View commit details
    Browse the repository at this point in the history

  4. use slimmer Pod structure across code base 

    With this slimmer Pod structure, Cilium won't need to convert a Pod into
another structure that Cilium understands. This conversion will
automatically happen when doing the unmarshal of k8s event. Thus,
providing better memory management as well as CPU consumption since
Cilium will only unmarshal the fields that actually need.

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed May 6, 2020
    Configuration menu
    Copy the full SHA
    16ce14e View commit details
    Browse the repository at this point in the history