coccinelle: Use Docker image to patch issues #11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developers likely won't have Coccinelle installed on their host so we should allow them to use the Coccinelle Docker image to fix any issue found by the GitHub action. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
the
release-note/misc
We can make use of the assignment operator metavariable to simplify the const.cocci script. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/cocci-fix-using-docker
branch
from
0c99ad8
to
5716bef
Compare
borkmann
approved these changes
May 6, 2020
tklauser
approved these changes
May 6, 2020
joestringer
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers likely won't have Coccinelle installed on their system so we should allow them to use the Coccinelle Docker image to fix any issue found by the GitHub action.
Second commit is a simplification of
const.cocciscript. No intended functional change.