Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubble-relay: Add gops agent #11372

Merged
merged 2 commits into from May 6, 2020
Merged

Conversation

gandro
Copy link
Member

@gandro gandro commented May 6, 2020

It is enabled by default so that cilium-sysdump will be able to dump stack traces. The Dockerfile is updated to statically link the gops binary so it is runnable in the scratch image.

Manually verified with cilium/cilium-sysdump#86 on minikube.

gandro added 2 commits May 6, 2020 19:51
The Dockerfile is based on `scratch`, therefore we must build a
statically linked gops binary for the container image.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
It is enabled by default so that cilium-sysdump will be able to dump
stack traces.

Fixes: #11227

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro requested a review from a team May 6, 2020 18:26
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 6, 2020
@gandro gandro added sig/hubble Impacts hubble server or relay release-note/misc This PR makes changes that have no direct user impact. labels May 6, 2020
@gandro
Copy link
Member Author

gandro commented May 6, 2020

test-me-please

Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.53% when pulling 2fa2239 on pr/gandro/hubble-relay-gops into e374eac on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 6, 2020
@joestringer joestringer merged commit 2f5f4be into master May 6, 2020
1.8.0 automation moved this from In progress to Merged May 6, 2020
@joestringer joestringer deleted the pr/gandro/hubble-relay-gops branch May 6, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants