New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubble-relay: Add gops agent #11372
Merged
Merged
hubble-relay: Add gops agent #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile is based on `scratch`, therefore we must build a statically linked gops binary for the container image. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
It is enabled by default so that cilium-sysdump will be able to dump stack traces. Fixes: #11227 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Please set the appropriate release note label. |
gandro
added
sig/hubble
Impacts hubble server or relay
release-note/misc
This PR makes changes that have no direct user impact.
labels
May 6, 2020
test-me-please |
rolinh
approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
glibsm
approved these changes
May 6, 2020
michi-covalent
approved these changes
May 6, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
sig/hubble
Impacts hubble server or relay
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is enabled by default so that cilium-sysdump will be able to dump stack traces. The Dockerfile is updated to statically link the gops binary so it is runnable in the
scratch
image.Manually verified with cilium/cilium-sysdump#86 on minikube.