Use slimmer protobuf structures for remaining k8s structures #11374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Martins <andre@cilium.io>
With this slimmer Node structure, Cilium won't need to convert a Node into another structure that Cilium understands. This conversion will automatically happen when doing the unmarshal of k8s event. Thus, providing better memory management as well as CPU consumption since Cilium will only unmarshal the fields that actually need. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
With this slimmer Namespace structure, Cilium won't need to convert a Namespace into another structure that Cilium understands. This conversion will automatically happen when doing the unmarshal of k8s event. Thus, providing better memory management as well as CPU consumption since Cilium will only unmarshal the fields that actually need. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
With this slimmer Service structure, Cilium won't need to convert a Service into another structure that Cilium understands. This conversion will automatically happen when doing the unmarshal of k8s event. Thus, providing better memory management as well as CPU consumption since Cilium will only unmarshal the fields that actually need. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
With this slimmer Endpoints structure, Cilium won't need to convert a Endpoints into another structure that Cilium understands. This conversion will automatically happen when doing the unmarshal of k8s event. Thus, providing better memory management as well as CPU consumption since Cilium will only unmarshal the fields that actually need. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
With this slimmer EndpointSlice structure, Cilium won't need to convert a EndpointSlice into another structure that Cilium understands. This conversion will automatically happen when doing the unmarshal of k8s event. Thus, providing better memory management as well as CPU consumption since Cilium will only unmarshal the fields that actually need. Signed-off-by: André Martins <andre@cilium.io>
aanm
added
sig/k8s
|
test-me-please |
Signed-off-by: André Martins <andre@cilium.io>
With this slimmer NetworkPolicy structure, Cilium won't need to convert a NetworkPolicy into another structure that Cilium understands. This conversion will automatically happen when doing the unmarshal of k8s event. Thus, providing better memory management as well as CPU consumption since Cilium will only unmarshal the fields that actually need. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/use-slimmer-protobuf-definitions-others
branch
from
133046e
to
378eac0
Compare
|
test-me-please |
|
Unable to debug k8s flakes due #11386 |
tgraf
approved these changes
May 7, 2020
| @@ -46,9 +47,7 @@ import ( | |||
| envoy_api_v2_core "github.com/cilium/proxy/go/envoy/api/v2/core" | |||
| envoy_api_v2_route "github.com/cilium/proxy/go/envoy/api/v2/route" | |||
| envoy_type_matcher "github.com/cilium/proxy/go/envoy/type/matcher" | |||
|
|
|||
There was a problem hiding this comment.
Your IDE is applying too much automation ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #11326 for remaining structures