bpf: Set DIRECT_ROUTING_DEV* in routed mode #11419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits drop the check for the mode if the NodePort BPF is enabled, which allows DIRECT_ROUTING_DEV* to be set in the "routed" mode (--enable-endpoint-routes=true). Previously, the NodePort BPF was broken with --enable-endpoint-routes=true. Fix: c5bcce4 ("datapath: Use direct routing iface for fwding NodePort requests") Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
kind/bug
|
Please set the appropriate release note label. |
2 similar comments
|
Please set the appropriate release note label. |
|
Please set the appropriate release note label. |
|
test-me-please |
brb
added
the
release-note/bug
borkmann
approved these changes
May 8, 2020
pchaigno
approved these changes
May 8, 2020
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits drop the check for the mode if the NodePort BPF is enabled, which allows
DIRECT_ROUTING_DEV*to be set in the"routed"mode (--enable-endpoint-routes=true).Previously, due to the check the NodePort BPF was broken with
--enable-endpoint-routes=true, and the direct routing mode"direct"can be used together with"routed"(both modes are sharing the same variable)./cc @pchaigno
Fix: c5bcce4 ("datapath: Use direct routing iface for fwding NodePort requests")