Doc: Update the unit test section for privileged tests #11433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
soumynathan
force-pushed
the
update-doc-to-add-instructions-to-run-privileged-unit-tests
branch
from
cf9adcb
to
bb155ae
Compare
joestringer
requested changes
May 8, 2020
joestringer
added
the
release-note/misc
soumynathan
force-pushed
the
update-doc-to-add-instructions-to-run-privileged-unit-tests
branch
from
bb155ae
to
14a4fea
Compare
christarazi
requested changes
May 8, 2020
pchaigno
requested changes
May 8, 2020
There was a problem hiding this comment.
Thanks for the improvement @soumynathan! A couple editing nits below.
soumynathan
force-pushed
the
update-doc-to-add-instructions-to-run-privileged-unit-tests
branch
2 times, most recently
from
a2201d6
to
f7fa64c
Compare
pchaigno
approved these changes
May 8, 2020
christarazi
requested changes
May 8, 2020
This PR adds instructions to the cilium documentation on how to run the 'privileged' unit tests. Fixes: cilium#11431 Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com>
soumynathan
force-pushed
the
update-doc-to-add-instructions-to-run-privileged-unit-tests
branch
from
f7fa64c
to
39d3abc
Compare
christarazi
approved these changes
May 27, 2020
|
Commit dfa206b18f8204fd4a7300a816a2c07fe00282b8 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
|
I'm not sure what just happened right there. I clicked "Rebase and merge" and GH's UI just bugged out and made a strange merge commit. @soumynathan Do you mind removing that commit from the PR? I will merge after. Edit: Looks like @pchaigno was able to handle it. Merging |
pchaigno
force-pushed
the
update-doc-to-add-instructions-to-run-privileged-unit-tests
branch
from
dfa206b
to
39d3abc
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instructions to the cilium documentation on how to
run the 'privileged' unit tests.
Fixes: #11431
Signed-off-by: Swaminathan Vasudevan svasudevan@suse.com