Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: Run GitHub Actions on master #11439

Merged
merged 1 commit into from May 12, 2020
Merged

.github: Run GitHub Actions on master #11439

merged 1 commit into from May 12, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented May 8, 2020

Running our GitHub Actions on every push to master should help us notice and find the origin of regressions if we ever let some fall between the cracks.

@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 8, 2020
@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label May 8, 2020
@pchaigno pchaigno marked this pull request as ready for review May 8, 2020 21:43
@pchaigno pchaigno requested a review from a team as a code owner May 8, 2020 21:43
@coveralls
Copy link

coveralls commented May 8, 2020 •
edited

Coverage Status

Coverage decreased (-0.01%) to 37.886% when pulling 4fedf12 on pr/pchaigno/run-github-actions-on-master into fb5a886 on master.

errordeveloper
errordeveloper reviewed May 11, 2020
View reviewed changes
.github/workflows/coccicheck.yaml
- pull_request
pull_request: []
push:
branches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this can be just one line branches: [ master ], if you like :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be push: { branches: [ master ] }, but I find that less readable...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm expecting we'll soon want to add the backport branches there, so probably not worth fixing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@pchaigno
.github: Run GitHub Actions on master
4fedf12 
Running our GitHub Actions on every push to master should help us notice
and find the origin of regressions if we ever let some fall between the
cracks.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/run-github-actions-on-master branch from f08a3a8 to 4fedf12 Compare May 11, 2020 12:20
@sayboras
Copy link
Member

@pchaigno I was not aware of this PR, otherwise I would have added master branch in 51934c8 as well.

As this PR is kind of ready, I will send update separately.

@pchaigno
Copy link
Member Author

As this PR is kind of ready, I will send update separately.

@sayboras Could you also remove the path filter from the new Helm lint GitHub action? We've had issues in the past with path filters on Required GitHub actions. Basically, those actions don't always run, but GitHub's UI still fails PRs on which they don't run. The Helm lint GitHub action isn't yet required, but we will probably want it required soon :-)

@sayboras
Copy link
Member

As this PR is kind of ready, I will send update separately.

Could you also remove the path filter from the new Helm lint GitHub action? We've had issues in the past with path filters on Required GitHub actions. Basically, those actions don't always run, but GitHub's UI still fails PRs on which they don't run. The Helm lint GitHub action isn't yet required, but we will probably want it required soon :-)

Noted and thanks 💯

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 12, 2020
@maintainer-s-little-helper
Copy link

Commit fd77b5c3c922fd5d5524f46199dfd1eb5890c259 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 12, 2020
@gandro
Copy link
Member

gandro commented May 12, 2020

@pchaigno When I pressed Rebase and Merge (we don't have "create a merge commit" enabled on this repo), GitHub for some reason just pushed a merge commit into this, making it unready to merge 😲

I'll remove my commit from the branch. Not sure if this is GitHub being buggy or if this actually related to the PR?

@errordeveloper
Copy link
Contributor

errordeveloper commented May 12, 2020 via email

@gandro gandro force-pushed the pr/pchaigno/run-github-actions-on-master branch from fd77b5c to 4fedf12 Compare May 12, 2020 07:41
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 12, 2020
@gandro
Copy link
Member

gandro commented May 12, 2020

I think 'update branch' button makes a merge commit.

Ah! If I accidentally clicked that, this would explain it.

@gandro
Copy link
Member

gandro commented May 12, 2020

I think 'update branch' button makes a merge commit.

Ah! If I accidentally clicked that, this would explain it.

On the other hand, I only pressed one single button and it completely blocked out the merge UI (with both buttons), with saying: "merge failed - please reload the page".

@gandro gandro merged commit 83648ec into master May 12, 2020
1.8.0 automation moved this from In progress to Merged May 12, 2020
@gandro gandro deleted the pr/pchaigno/run-github-actions-on-master branch May 12, 2020 07:47
sayboras added a commit to sayboras/cilium that referenced this pull request May 12, 2020
@sayboras
build(github): Enable helm-check action for master branch as well
1c7d048 
Related to
cilium#11439 (comment)

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras mentioned this pull request May 12, 2020
Merged
aanm pushed a commit that referenced this pull request May 12, 2020
@sayboras @aanm
build(github): Enable helm-check action for master branch as well
8b609ab 
Related to
#11439 (comment)

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@tklauser tklauser tklauser approved these changes

@borkmann borkmann borkmann approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pchaigno @coveralls @sayboras @gandro @errordeveloper @tklauser @borkmann @joestringer