Also cast to specific structure if obj is type of cache.DeletedFinalStateUnknown #11461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
the
release-note/bug
|
test-me-please |
…Unknown When casting to a networkpolicy, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
When casting to a services, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
When casting to a endpoints, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
…Unknown When casting to a endointslice, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
When casting to a CNP, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
When casting to a Pod, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
When casting to a Node, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
When casting to a Namespace, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
…nown When casting to a CiliumNode, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
…eUnknown When casting to a CiliumEndpoint, the k8s watcher might send a cache.DeletedFinalStateUnknown object to the event handler. Since the converter is not expecting this type, it will cause a warning to be printed in the logs which will be unexpected for users. This commit adds the ability for the function converter to cast the objects from cache.DeletedFinalStateUnknown to avoid printing such warning. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/ignore-obj-to-cilium-warnings
branch
from
0ffb379
to
6c5d8a2
Compare
|
test-me-please |
|
retest-runtime |
|
retest-net-next |
|
hit #11457 |
nebril
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11438