hubble-relay: add an option to run pprof #11465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
release-note/misc
gandro
approved these changes
May 11, 2020
sayboras
reviewed
May 11, 2020
| @@ -51,6 +53,9 @@ func New() *cobra.Command { | |||
| cmd.Flags().BoolVarP( | |||
| &f.debug, "debug", "D", false, "Run in debug mode", | |||
| ) | |||
| cmd.Flags().BoolVar( | |||
There was a problem hiding this comment.
What do think about supporting this flag in helm chart as well https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/charts/hubble-relay/templates/deployment.yaml#L39?
There was a problem hiding this comment.
Given that there is already such an option for the cilium agent, I'd say that it'd be good to have for hubble-relay as well, yes.
michi-covalent
approved these changes
May 11, 2020
glibsm
approved these changes
May 11, 2020
|
test-me-please |
1 similar comment
|
test-me-please |
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/hubble-relay-pprof
branch
from
7acf745
to
a7817f7
Compare
|
test-me-please |
aanm
approved these changes
May 13, 2020
|
retest-4.9 |
|
retest-runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11460