helm: add bpf-policy-map-max option #11478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
joestringer
added
needs-backport/1.7
release-note/minor
joestringer
requested changes
May 11, 2020
There was a problem hiding this comment.
Thanks for the submisson!
The helm lint check failed:
https://github.com/cilium/cilium/pull/11478/checks?check_run_id=664504076
I believe you will need to run make -C install/kubernetes/ and commit the results.
The source of the default value origin is: v1.7/cmdref/cilium-agent Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
|
test-me-please |
joestringer
approved these changes
May 11, 2020
|
test-me-please |
aanm
approved these changes
May 12, 2020
|
K8s-1.11-Kernel-netnext CI run hit known flake #11442 . I'm happy to override and mark this as ready-to-merge based upon the above findings. |
joestringer
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.4
tklauser
added a commit
that referenced
this pull request
May 15, 2020
The policyMapMax helm option was introduced after the mapDynamicSizeRatio option in #11478. Thus, the fact that explicitly specifying the maximum disables the dynamic sizing of the policy map was not mentioned in the upgrade guide. Document this now. While at it, also fix the name of the helm option for the dynamic sizing in the upgrade guide. It was using the command line option name, not the helm option name. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
joestringer
pushed a commit
that referenced
this pull request
May 15, 2020
The policyMapMax helm option was introduced after the mapDynamicSizeRatio option in #11478. Thus, the fact that explicitly specifying the maximum disables the dynamic sizing of the policy map was not mentioned in the upgrade guide. Document this now. While at it, also fix the name of the helm option for the dynamic sizing in the upgrade guide. It was using the command line option name, not the helm option name. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source of the default value origin is: v1.7/cmdref/cilium-agent
I faced an issue today which solution and problem statement is described here #9117
This PR adds an option to let users override the default value
16384.Special notes for your reviewer:
Please backport to
v1.7releaseSigned-off-by: Alex Szakaly alex.szakaly@gmail.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes:
N/A