v1.7 backports 2020-05-12 #11488
Merged
v1.7 backports 2020-05-12 #11488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
backport/1.7
kind/backports
qmonnet
force-pushed
the
pr/v1.7-backport-2020-05-12
branch
from
ba667a3
to
7513cb2
Compare
|
never-tell-me-the-odds |
gandro
approved these changes
May 12, 2020
[ upstream commit 5f246ba ] This PR fixes the NOTES.txt file to reflect the correct action at the upper level, when preflight alone is installed. Also adds the NOTES.txt file that was missing for hubble-ui and handles the hubble-ui and hubble-cli text in the upper level NOTES.txt file. Fixes: #11245 Signed-off-by: Swaminathan Vasudevan <svasudevan@suse.com> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
[ upstream commit 69849ee ] Previously, DeleteEndpoints() invocation might have sent DeleteService event (handled by pkg/k8s/watcher), if a service didn't have any endpoint left. This led to a double removal of the service in pkg/service, as kube-apiserver sends a dedicated Service object removal update, which is handled by DeleteService() which sends DeleteService event. This triggered "service not found" warning msg. To fix this, send UpdateService event instead of DeleteService from deleteEndpoints(), which would trigger only update in svc backends. The removal of a service is handled by a separate event anyways. Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/v1.7-backport-2020-05-12
branch
from
7513cb2
to
6548f68
Compare
|
never-tell-me-the-odds |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTES.txtin thehubble-uifolder - see Improve Helm post-setup NOTES #11269 (comment)install/kubernetes/cilium/templates/NOTES.txtOnce this PR is merged, you can update the PR labels via: