Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/endpoint: return NamedPorts model consistently #11490

Merged
merged 1 commit into from May 12, 2020
Merged

pkg/endpoint: return NamedPorts model consistently #11490

merged 1 commit into from May 12, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented May 12, 2020

We need to return the NamedPorts consistently across calls of
getNamedPortsModel function. This avoids unnecessary CEP updates to
kube-apiserver.

Fixes: 3a72ffc ("api: Add named ports")
Signed-off-by: André Martins andre@cilium.io

@aanm
pkg/endpoint: returned NamedPorts model consistently
9abc960 
We need to return the NamedPorts consistently across calls of
getNamedPortsModel function. This avoids unnecessary CEP updates to
kube-apiserver.

Fixes: 3a72ffc ("api: Add named ports")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label May 12, 2020
@aanm aanm requested a review from a team as a code owner May 12, 2020 10:58
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 12, 2020
@aanm
Copy link
Member Author

aanm commented May 12, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 37.85% when pulling 9abc960 on pr/stop-unnecessary-cep-updates into 8b609ab on master.

@aanm aanm changed the title pkg/endpoint: returned NamedPorts model consistently pkg/endpoint: return NamedPorts model consistently May 12, 2020
@aanm aanm merged commit 74cc967 into master May 12, 2020
1.8.0 automation moved this from In progress to Merged May 12, 2020
@aanm aanm deleted the pr/stop-unnecessary-cep-updates branch May 12, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanm @coveralls @tgraf