Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: Do not define mount type when not using NFS #11505

Merged
merged 1 commit into from May 12, 2020
Merged

vagrant: Do not define mount type when not using NFS #11505

merged 1 commit into from May 12, 2020

Conversation

vadorovsky
Copy link
Member

Vagrant 2.2.9 does not accept defining the type field as an empty
string, but it allows to not define it.

Fixes: #11504
Signed-off-by: Michal Rostecki mrostecki@opensuse.org

@vadorovsky
vagrant: Do not define mount type when not using NFS
9e11a1c 
Vagrant 2.2.9 does not accept defining the `type` field as an empty
string, but it allows to not define it.

Fixes: cilium#11504
Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
@vadorovsky vadorovsky added kind/bug This is a bug in the Cilium logic. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels May 12, 2020
@vadorovsky vadorovsky requested a review from aanm May 12, 2020 19:10
@vadorovsky vadorovsky requested a review from a team as a code owner May 12, 2020 19:10
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 12, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 37.839% when pulling 9e11a1c on mrostecki:vagrant-mnt-type into 6817b28 on cilium:master.

@aanm aanm merged commit 8e86001 into cilium:master May 12, 2020
1.8.0 automation moved this from In progress to Merged May 12, 2020
@vadorovsky vadorovsky deleted the vagrant-mnt-type branch May 12, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vagrant 2.2.9: Error when the mount type is ""
3 participants
@vadorovsky @coveralls @aanm