New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable Prometheus metrics in K8sHubbleTest #11508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
release-note/ci
This PR makes changes to the CI.
sig/hubble
Impacts hubble server or relay
labels
May 12, 2020
gandro
added
the
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
May 13, 2020
gandro
reviewed
May 13, 2020
nebril
approved these changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing aside what gandro pointed out.
For now the test is pretty basic, just send curl to /metrics and look for some metrics that are supposed to be there. Fixes: #11498 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/prometheus
branch
from
May 13, 2020 15:42
3244a6c
to
bcf9ef9
Compare
test-me-please |
gandro
approved these changes
May 14, 2020
retest-runtime |
retest-4.9 |
rolinh
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dont-merge/needs-rebase
This PR needs to be rebased because it has merge conflicts.
release-note/ci
This PR makes changes to the CI.
sig/hubble
Impacts hubble server or relay
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now the test is pretty basic, just send curl to /metrics and
look for some metrics that are supposed to be there.
Fixes: #11498
Signed-off-by: Michi Mutsuzaki michi@isovalent.com