Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable Prometheus metrics in K8sHubbleTest #11508

Merged
merged 1 commit into from May 15, 2020
Merged

Conversation

michi-covalent
Copy link
Contributor

For now the test is pretty basic, just send curl to /metrics and
look for some metrics that are supposed to be there.

Fixes: #11498

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@michi-covalent michi-covalent added release-note/ci This PR makes changes to the CI. sig/hubble Impacts hubble server or relay labels May 12, 2020
@michi-covalent michi-covalent requested a review from a team as a code owner May 12, 2020 21:02
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 12, 2020
@coveralls
Copy link

coveralls commented May 12, 2020

Coverage Status

Coverage decreased (-0.001%) to 38.036% when pulling bcf9ef9 on pr/michi/prometheus into 96384f0 on master.

@gandro gandro added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label May 13, 2020
test/k8sT/hubble.go Outdated Show resolved Hide resolved
test/k8sT/hubble.go Outdated Show resolved Hide resolved
Copy link
Member

@nebril nebril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing aside what gandro pointed out.

For now the test is pretty basic, just send curl to /metrics and
look for some metrics that are supposed to be there.

Fixes: #11498

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@gandro
Copy link
Member

gandro commented May 14, 2020

test-me-please

@gandro
Copy link
Member

gandro commented May 14, 2020

retest-runtime

@gandro
Copy link
Member

gandro commented May 14, 2020

retest-4.9

@aanm aanm merged commit 1a51f4c into master May 15, 2020
1.8.0 automation moved this from In progress to Merged May 15, 2020
@aanm aanm deleted the pr/michi/prometheus branch May 15, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. release-note/ci This PR makes changes to the CI. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

CI/Hubble: Enable and validate Hubble metrics subsystem
6 participants