Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add make render-docs-live-preview target #11536

Merged
merged 2 commits into from May 19, 2020
Merged

doc: Add make render-docs-live-preview target #11536

merged 2 commits into from May 19, 2020

Conversation

michi-covalent
Copy link
Contributor

2 commits:

  • Update spelling_wordlist.txt to include some words that are missing in the OS X English dictionary.
  • Add make render-docs-live-preview for live preview!

Update spelling_wordlist.txt to include some words that are missing
in the OS X English dictionary.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
- Install dependencies inside a virtualenv using pipenv and run
  sphinx-autobuild for real-time preview.
- Update PyYAML dependency to 5.3.1. Pipenv complains about beta
  version dependencies by default.
- Update the Documentation page.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested review from a team as code owners May 15, 2020 01:38
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 May 15, 2020
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label May 15, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 37.032% when pulling c620876 on pr/michi/live into ffe9cb2 on master.

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michi-covalent
Copy link
Contributor Author

test-me-please

@tklauser
Copy link
Member

Runtime tests failed on known flake #11512 (https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/192/), thus merging without re-running.

@tklauser tklauser merged commit 38abe89 into master May 19, 2020
1.8.0 automation moved this from In progress to Merged May 19, 2020
@tklauser tklauser deleted the pr/michi/live branch May 19, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants